Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device info versioning #8222

Merged
merged 3 commits into from Jul 26, 2021
Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Adds versioning to device info endpoint
  • Defaults to v1
  • Updates code for fetching device info to send version
  • Updates code for fetching device info to filter returned info recognized keys
  • Adds tests for different versions of endpoint
  • Fixes miscellanous CLI bug where errors would not get properly reported

Reviewer guidance

Anything missing?

I checked the cross-version one way by changing the requested version to "1" in the Network client, then verifying that it returned None for subset_of_users_device. Have not tested the other way.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester July 26, 2021 19:51
@rtibbles rtibbles added this to the 0.15.0 milestone Jul 26, 2021
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🦖

@bjester bjester merged commit 0415b6d into learningequality:develop Jul 26, 2021
@jredrejo jredrejo mentioned this pull request Jul 28, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants