Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure adhoc groups have a name. #8242

Merged
merged 3 commits into from Jul 29, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 29, 2021

Summary

  • Ensure all adhoc groups are created with a name
  • Adds an upgrade task to add a name to all existing unnamed adhoc groups

References

Fixes issue with adhoc groups not getting deserialized during syncs

Reviewer guidance

I couldn't do a simple change to the default behaviour for adhocgroups to allow deserialization of empty names.

I think it might be possible by overriding the full clean method of the AdHocGroup model, but it seemed good to get this in for now, and assess if follow up was needed.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 29, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jul 29, 2021
rtibbles and others added 2 commits July 29, 2021 09:22
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rtibbles rtibbles merged commit 02fc882 into learningequality:release-v0.15.x Jul 29, 2021
@rtibbles rtibbles deleted the adhoc_group_names branch July 29, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants