Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify file URL generation. #8252

Merged
merged 3 commits into from Aug 3, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 2, 2021

Summary

  • The zipcontent URL is now a special case, so this simplifies the generation of file URLs to always be the same, regardless of file type
  • The current storage_url was not being used by the HTML5 rendering any more, so there is no need for this behaviour

References

Cleanup from #7989 and #8005
Prep work for #8070

Reviewer guidance

Does content still load?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Only reference zipcontent in special case.
@rtibbles rtibbles added TODO: needs review Waiting for review P2 - normal Priority: Nice to have labels Aug 2, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Aug 2, 2021
@indirectlylit indirectlylit merged commit b4531c2 into learningequality:develop Aug 3, 2021
@rtibbles rtibbles deleted the url_simplification branch August 17, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - normal Priority: Nice to have TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants