Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass implementation of new paginated/inlined topic rendering. #8302

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 16, 2021

Summary

  • Does initial pagination and inlining of topic render
  • Does not implement to spec of designs!

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles marked this pull request as draft August 16, 2021 22:17
@rtibbles rtibbles linked an issue Aug 17, 2021 that may be closed by this pull request
@rtibbles rtibbles marked this pull request as ready for review August 26, 2021 21:17
@marcellamaki marcellamaki merged commit 207a197 into learningequality:develop Aug 30, 2021
@indirectlylit indirectlylit added the changelog Important user-facing changes label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for arbitrarily-sized topics
3 participants