Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop polling until admin actually initiates the session #8328

Merged

Conversation

jredrejo
Copy link
Member

Summary

When syncing users in the setup wizard using admin credentials, polling was being stopped before the admin account could sign in to begin to work, so import was not possible.
This PR ensures polling does not stop until the admin has started his/her session.

References

Closes: #8326

Reviewer guidance

Try to setup a new device using admin credentials to sync with a server that has some latency.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Aug 18, 2021
@jredrejo jredrejo assigned rtibbles and unassigned rtibbles Aug 18, 2021
@jredrejo jredrejo requested a review from rtibbles August 18, 2021 18:40
@rtibbles rtibbles merged commit b061519 into learningequality:release-v0.15.x Aug 19, 2021
@jredrejo jredrejo deleted the fix_tasks_completion branch August 20, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup wizard does not allow importing users when using admin credentials
2 participants