Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release process docs #8346

Merged
merged 1 commit into from Aug 31, 2021

Conversation

indirectlylit
Copy link
Contributor

Summary

Following up from planning and discussions with @marcellamaki

Release process documentation has been maintained in Notion by JB rather than in RTD.

References

Reviewer guidance

Would love some eyes on this set of changes to make sure it will work for release tracking and engineering docs


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me -- meaning, for my role, I find it easy to follow -- but I'm going to hold off on approving/merging just for a day so that perhaps @rtibbles or @nucleogenesis can take a peek because I'm sure they have some release context that I don't, and just want to make sure if they have any comments those can be addressed.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, as it's mostly just transferring this into notion docs, so let's merge this and move on!

@rtibbles rtibbles merged commit a378896 into learningequality:release-v0.15.x Aug 31, 2021
@indirectlylit
Copy link
Contributor Author

Yeah, the more interesting piece will be whether the new tracker table templates and checklists work and are maintainable

https://www.notion.so/learningequality/Kolibri-releases-3119700069ff42e984da88ee11fe13a3

@indirectlylit indirectlylit deleted the releases branch September 2, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants