Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate sync credentials before task enqueue #8349

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Aug 25, 2021

Summary

To avoid leakage of user credentials, validate them before queuing SoUD sync. The validation will generate the appropriate certificates if they do not exist, allowing for future authentication without user credentials.

Reviewer guidance

Run through setup wizard for the following scenarios:

  1. Provision from full facility import
  2. Provision as learn-only device

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added this to the 0.15.0 milestone Aug 26, 2021
@bjester bjester added the TODO: needs review Waiting for review label Aug 26, 2021
@bjester bjester marked this pull request as ready for review August 26, 2021 17:08
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, automated syncing still proceeds as expected.

@rtibbles rtibbles merged commit e3f54a1 into learningequality:release-v0.15.x Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants