New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all user strings with instances of 'active/inactive' #8421
Remove all user strings with instances of 'active/inactive' #8421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the purposes of getting this in before String Freeze - go for it. I don't see anything here that would block that.
However, a follow-up issue should be made where a dev goes through and cleans up - not just the comments, but also to verify that all unnecessary functionality is removed - including one or more completely useless components.
I think that leaving the comments like so will be helpful in navigating that work so no need to remove them yet.
lessonActiveLabel: 'Active', | ||
lessonInactiveLabel: 'Inactive', | ||
}, | ||
// computed: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LessonActive
component seems to be used in AssignmentSummary
(not sure where in the app that is exactly but maybe in Coach > Plan somewhere)
This component has one job which is to say "Active" or "Inactive" based on the given value.
So this component should be refactored out of our app altogether or we should keep the strings to avoid them missing in AssignmentSummary
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming now that we can also just remove AssignmentSummary
as it is an unused component.
activeQuizLabel: 'Active', | ||
inactiveQuizLabel: 'Inactive', | ||
}, | ||
// computed: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as in the LessonActive
changes. This is used in ReportsGroupReportQuizHeader
currently so we'll need to account for that with the refactor by either adding or borrowing a newer string in place of this Active|Inactive one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReportsGroupReportQuizQuestionListPage.vue
and ReportsGroupReportQuizLearnerListPage.vue
have these headers for "status" and "average score" - @jtamiace safe to just remove the Status?
Seems also that there may be a bug where the average score isn't showing that seems unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding this up for now until we can confirm that the strings we would want to update these to open/closed
and visible to learner
for quizzes/lessons are in a place where we can implement these changes after string freeze.
I misunderstood that these strings are not actually displaying anywhere.
Summary
For the time being I just commented out the relative pieces of code so the strings do not get extracted. Ideally we should delete them, but this should be enough to avoid them ending up on Crowdin.
My commenting out may not be the prettiest, but it seems to do the job, and at least I did not see any errors in the terminal or the browser console.
References
Fixes #8420
Reviewer guidance
Test if pages:
work as expected.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)