Hybrid learning home page MVP - for string freeze #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no matter of their classess memberships, access to unasigned resources settings, or whether they're signed-in or anonymous. From now on, everyone wil lbe taken to the home page which content will adjust correspondingly.
so it's consistent with spaces between sections on the home page
Revert commit 7af8593 because home page is not yet functioning fully for guest users. As soon as it can display "Explore Channels", new logic can be used again.
MisRob
changed the title
marcellamaki
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
This looks good for string freeze (and like a great MVP as well from the quick larger code read-through and manual QA I did). Nice work @MisRob - thanks for getting this in and for the great MVP work. Looking forward to a more thorough review on your follow up PR that has more details about your implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Home page work in progress for the string freeze. The feature will be described and reviewed in another PR.
Should contain all strings from #8137 plus the two more following strings that are outside of the scope of the #8137 used on Home Page designs:
I temporarily placed these two strings into
commonLearnStrings.js