Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 500+ status codes when requesting a SoUD sync #8446

Merged
merged 1 commit into from Sep 18, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Sep 17, 2021

Summary

  • Fixed some assertions in tests
  • Added test for handling ConnectionError in request
  • Fixed issue where using requests.exceptions.ConnectionError made Python report that it was not derived from BaseException
  • Handle 500+ status codes from the queue endpoint by initiating ttl back off

Reviewer guidance

Tests cover the changes?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…quests.

Handle 500+ errors in soud sync requests.
@rtibbles rtibbles added the TODO: needs review Waiting for review label Sep 17, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Sep 17, 2021
Copy link
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the scheduling code well enough to say anything definitive around how the tests work, but the code change itself seems wise (though I added a comment about raise_for_status as a possible alternative pattern, noting that it raises requests.exceptions.HTTPError instead, so we'd then need to catch that too).

kolibri/core/public/utils.py Show resolved Hide resolved
@rtibbles rtibbles merged commit a7d1361 into learningequality:release-v0.15.x Sep 18, 2021
@rtibbles rtibbles deleted the 500_soud branch September 18, 2021 14:16
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants