Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid learning progress bar #8452

Merged
merged 1 commit into from Sep 27, 2021

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Sep 21, 2021

Summary

This is a progress bar component that JB has prepared for cards on the new hybrid learning home page. @marcellamaki mentioned that it might be helpful for some of her work on hybrid learning so sharing here.

Screenshots from cards that are using it on my home page branch:

Screenshot from 2021-09-21 14-57-12
Screenshot from 2021-09-21 14-57-38

References

Part of #8137

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob modified the milestones: 0.15, 0.15.0 Sep 21, 2021
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 21, 2021
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @MisRob - thank you!

@marcellamaki marcellamaki merged commit 9c150cb into learningequality:develop Sep 27, 2021
@MisRob MisRob deleted the progress-bar branch October 20, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants