New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content metadata optimizations #8492
Content metadata optimizations #8492
Conversation
8b93dc6
to
4776c0f
Compare
c28f468
to
2d7833d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's impossible to test this PR using the frontend as https://github.com/learningequality/kolibri/blob/release-v0.15.x/kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/ActivityButtonsGroup.vue#L56 is broken (plugin_data.learningActivities
is undefined)
is there a known workaround (appart from trying to debug and solve it) ?
Sorry @jredrejo - looks like I need to map from snake case to camelCase after my last commit, will update. |
thanks, let me know when I can test it |
Have updated so that it can be tested - have not made any updates as yet changing the integer fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me (there's an odd linting error that has not been introduced in this commit and it's already resolved in the v0.15.x branch) so rebasing should solve it.
I have tested it as much as I have been able and searching, upgrades & migrations work. Performance is hard to compare without a previous reference but the app works fine on my laptop.
There are a good amount of frontend errors that seem to be related to things this PR is not affecting, but just in case, this is the list I have seen:
- Continue missing icon errors at Sub.svgIconComponent
- http://localhost:8080/es-es/learn/ page keeps in blank with the loading animation forever until one tab is clicked
- No way to clean the search filters
vue-router.esm.js:2062 Uncaught (in promise) Error: Avoided redundant navigation to current location: "/library?languages=es".
error after searching filtering by language or channel
I think all these problems are related to different PR or issues, but I have doubts with the latest one. If this PR is not causing this issue, we can approve it
Yeah, I don't think any of these are caused by this PR. |
a6446ad
to
cdf29f9
Compare
Reverting to draft here until I can update the bit generation to come stably and consistently from le-utils. |
used for generating bits.
Update annotation to fix bug.
0aadfb4
to
e2088c4
Compare
Summary
has_labels
method to the ContentNode queryset that does bitwise matching of one or more labels for a specific categorical metadata fieldReferences
Follow up to #8488
Reviewer guidance
Any areas of the code where more comments might be useful?
Any way to optimize the available labels code further?
Still needs tests.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)