Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lessons playlist cards #8541

Conversation

marcellamaki
Copy link
Member

Summary

Fixes broken cards on the lessons playlist page (access through classes)

New layout in alignment with Figma and other hybrid learning designs

Card links work

References

Figma - Lesson Overview Page

Reviewer guidance

Fairly straightforward UI changes:

  • Layout/mobile responsiveness
  • card links work (back button fix not included)

Desktop
Screen Shot 2021-10-26 at 12 15 04 PM

Mobile
Screen Shot 2021-10-26 at 12 17 14 PM


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…cards, rather than modify existing components, to prevent regressions
…t content bookmark status in LearningActivityBar
…cards, rather than modify existing components, to prevent regressions
…ch cards are used and grid at different sizes
…rking. No translations/string mapping - using ids
@marcellamaki
Copy link
Member Author

Superseded by #8548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants