-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lessons playlist cards #8541
Closed
marcellamaki
wants to merge
38
commits into
learningequality:release-v0.15.x
from
marcellamaki:fix-lessons-playlist-cards
Closed
Fix lessons playlist cards #8541
marcellamaki
wants to merge
38
commits into
learningequality:release-v0.15.x
from
marcellamaki:fix-lessons-playlist-cards
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cards, rather than modify existing components, to prevent regressions
…t content bookmark status in LearningActivityBar
…instead of ContentCardGroupGrid
…cards, rather than modify existing components, to prevent regressions
…ch cards are used and grid at different sizes
…rking. No translations/string mapping - using ids
…ity of use and better card alignment
Add channel title and thumbnail data to normalizeContentNode.
Superseded by #8548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken cards on the lessons playlist page (access through classes)
New layout in alignment with Figma and other hybrid learning designs
Card links work
References
Figma - Lesson Overview Page
Reviewer guidance
Fairly straightforward UI changes:
Desktop
Mobile
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)