Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search updates #8570

Merged
merged 21 commits into from
Nov 2, 2021
Merged

Search updates #8570

merged 21 commits into from
Nov 2, 2021

Commits on Oct 30, 2021

  1. Use DjangoJSONEncoder for bootstrapping plugin data to allow datetimes.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    5cf317d View commit details
    Browse the repository at this point in the history

  2. Bootstrap full available channel data into the learn page.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    f4bad16 View commit details
    Browse the repository at this point in the history

  3. Update useChannels composable to use bootstrapped channel data. 

    Update all channel references to use useChannels.
    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    e917afb View commit details
    Browse the repository at this point in the history

  4. Consolidate search logic in useSearch composable. 

    Consolidate search chips in SearchChips component.
    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    85688cb View commit details
    Browse the repository at this point in the history

  5. Don't show channels selector on within channel search. 

    Cleanup nonexistent prop.
    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    80ea591 View commit details
    Browse the repository at this point in the history

  6. Fix channel breadcrumbs display.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    d0d8065 View commit details
    Browse the repository at this point in the history

  7. Generalize channel specificity for search to topic specificity.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    07bac8d View commit details
    Browse the repository at this point in the history

  8. Simplify routes. Add topics search route.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    dd679dc View commit details
    Browse the repository at this point in the history

  9. Fix search chips display. Add translation for no categories.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    661012e View commit details
    Browse the repository at this point in the history

  10. Fix search clearing.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    1dd4670 View commit details
    Browse the repository at this point in the history

  11. Consolidate library page handler into a single function.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    f07bd2e View commit details
    Browse the repository at this point in the history

  12. Fix breadcrumbs for route changes.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    e9bd98a View commit details
    Browse the repository at this point in the history

  13. Clean up unused constants, components and functionality.

    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    e3f4884 View commit details
    Browse the repository at this point in the history

  14. Upgrade kolibri-constants. 

    Clean up lock file.
Add additional nonconforming keys.
    @rtibbles
    rtibbles committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    dcdf284 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Add code comments to convoluted categories nesting code.

    @rtibbles
    rtibbles committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    5aed660 View commit details
    Browse the repository at this point in the history

  2. Handle search clearing properly in all cases. 

    Remove width setting only used by non-existent route.
Remove TOPICS_CHANNEL and TOPICS_ROOT references.
Fix JS tests.
    @rtibbles
    rtibbles committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    67d1f18 View commit details
    Browse the repository at this point in the history

  3. Rename tree viewset parameter to avoid collision with contentnode fil… 

    …ter.
    @rtibbles
    rtibbles committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    0c1ea94 View commit details
    Browse the repository at this point in the history

  4. Add redirect to handle historic channels page. 

    Remove breadcrumbs reference to Library.
    @rtibbles
    rtibbles committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    9331bfd View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Add full test coverage to useSearch module. Fix bugs and cleanup.

    @rtibbles
    rtibbles committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    d5ffc8e View commit details
    Browse the repository at this point in the history

  2. Don't display chips for null or empty keywords value.

    @rtibbles
    rtibbles committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    13d0e19 View commit details
    Browse the repository at this point in the history

  3. Update searchInputValue to always be empty string for no value.

    @rtibbles
    rtibbles committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    22d330f View commit details
    Browse the repository at this point in the history