Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page follow-up fixes #8574

Merged
merged 4 commits into from Nov 2, 2021

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Nov 2, 2021

Summary

(1) fixes missing progress bars in "Continue learning on your own" section
(2) makes sure that content nodes that have progress 0 won't get displayed in "Continue learning from your classes/on your own" sections even though API returns them as resumable - frontend fix for #8573
(3) fixes alignment of learning activity label

Before After
Screenshot from 2021-11-02 12-20-17 Screenshot from 2021-11-02 12-26-07

@pcenov I also checked why duration information is not displayed on cards and on my server it's because API returns null values. Cards are ready to display duration when it's available. For example, for video resources it looks like:

Screenshot from 2021-11-02 12-31-56

so hopefully it will work as soon as we have all data available, but would be definitely good to check on it again. Thank you.

References

Closes #8553

Reviewer guidance

Preview cards on the home page in "Continue learning from your classes/on your own" sections

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added this to the 0.15.0 milestone Nov 2, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM! Thanks Misha!

@rtibbles rtibbles merged commit 376811b into learningequality:release-v0.15.x Nov 2, 2021
@pcenov
Copy link
Member

pcenov commented Nov 3, 2021

Tested and verified as fixed - looking great! Thanks @MisRob

@MisRob MisRob deleted the home-page-fixes branch November 4, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid Learning Home Page - Follow up issues
4 participants