Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that a channel exists locally before trying to import content #8679

Merged
merged 1 commit into from Nov 17, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 12, 2021

Summary

  • Adds some simple validation to the importchannel command

References

Fixes #7506

Reviewer guidance

Does importcontent still work as expected?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 12, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 12, 2021
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's totally harmless. I'd maybe refactor it to assign options["channel_id"] to a variable to avoid several dict lookups in the same function

@rtibbles rtibbles merged commit 25f2a3e into learningequality:release-v0.15.x Nov 17, 2021
@rtibbles rtibbles deleted the no_type_error branch November 17, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importcontent gives a TypeError if channel metadata is not present
2 participants