Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach view: hide dropdown when there are no practice quizzes #8684

Merged

Conversation

sairina
Copy link
Contributor

@sairina sairina commented Nov 12, 2021

Summary

Frame Description of expected behavior
Screen Shot 2021-11-12 at 3 25 25 PM Coach user has access to channels with folders that have practice quizzes (channel quizzes) - dropdown menu with option to select a practice quiz is visible
Screen Shot 2021-11-12 at 3 25 57 PM Coach user does not have access to channels that have folders with practice quizzes - normal KRouterLink to create a new quiz is visible

References

Addresses #8632

Reviewer guidance

For manual testing:

Frame 1: Coach user with practice quizzes on device

  1. Sign in as super admin
  2. Make sure there is a channel with a practice quiz on the device
  3. Go to Coach in the sidenav
  4. In Coach, click on Plan tab > Quizzes subtab
  5. Check to see that the "New quiz" button is a dropdown (has a triangle) and that "Select a channel quiz" is an option (for the moment, it is "channel quiz" but when the strings are merged, this will become "practice quiz")

Frame 2: Coach user with NO practice quizzes in any channel on device

  1. Sign in as super admin
  2. Make sure there are NO channels with practice quizzes on the device
  3. Go to Coach in the sidenav
  4. In Coach, click on Plan tab > Quizzes subtab
  5. Check to see that the "New quiz" button is not a dropdown (without a triangle) and that you are directed to creating a new quiz when you click on this button

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sairina sairina changed the base branch from release-v0.15.x to develop November 12, 2021 21:17
@sairina sairina added the TODO: needs gherkin update Add to our manual integration tests label Nov 12, 2021
@sairina sairina added the TODO: needs review Waiting for review label Nov 12, 2021
@sairina sairina marked this pull request as ready for review November 12, 2021 23:38
@sairina sairina changed the title Coach view: hide dropdown option for practice quiz selection (for quizzes) Coach view: hide dropdown when there are no practice quizzes Nov 12, 2021
@rtibbles rtibbles changed the base branch from develop to release-v0.15.x November 16, 2021 01:31
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works perfectly (although I had some strange issues with the query not working properly at first until I reimported content, I am assuming it had to do with weird local DB state of mine).

Just needs to rebase the relevant commits on top of 0.15!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs gherkin update Add to our manual integration tests TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants