Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "View learner devices" link to appear in all reports pages #8715

Merged

Conversation

sairina
Copy link
Contributor

@sairina sairina commented Nov 16, 2021

Summary

This PR makes it so that the "View learner devices link" is available for:

  • Reports > Lessons
  • Reports > Quizzes
  • Reports > Groups
  • Reports > Learners

2021-11-16 15 48 14

References

Addresses #8475

Reviewer guidance

  • Double-check to see that no other pages with this ReportControls component is showing this link.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sairina sairina added the TODO: needs review Waiting for review label Nov 16, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checks out - animation shows correct behaviour.

@rtibbles rtibbles merged commit cdbbea6 into learningequality:release-v0.15.x Nov 17, 2021
@rtibbles rtibbles linked an issue Nov 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'View learner devices' link present only on 'Reports > Quizzes'
2 participants