Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do permanent redirect from /user to /auth. #8748

Merged
merged 2 commits into from Nov 19, 2021
Merged

Do permanent redirect from /user to /auth. #8748

merged 2 commits into from Nov 19, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 19, 2021 •
edited

Summary

  • Sets up a permanent redirect from /user to /auth

References

Fixes #8662

Reviewer guidance

Does loading /user redirect to /auth then //auth?
Does loading //user redirec to //auth?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 19, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 19, 2021
indirectlylit
indirectlylit approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@indirectlylit indirectlylit merged commit 387eaed into learningequality:release-v0.15.x Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indirectlylit indirectlylit indirectlylit approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

add redirect from '/user' to '/auth'
2 participants
@rtibbles @indirectlylit