Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync/register interface #8753

Merged

Conversation

marcellamaki
Copy link
Member

Summary

Rather than having a visible but disabled "Register" button for registered facilities, the option to register facilities is now in a kebab menu, with the sync button more prominent. Inversely, for non-registered facilities, the register button is prominent, with the sync button in a kebab menu.

Not already registered
Screen Shot 2021-11-19 at 1 04 00 PM

Already registered
Screen Shot 2021-11-19 at 1 16 35 PM

References

Fixed #7672

Reviewer guidance

I am not actually sure if this is a sufficient change to account for all of the conditions @jamalex described? Any other considerations I should account for?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working perfectly.
Code looks good to me (I dislike the need to use nextTick to set the focus, it seems a brittle trick but that's a vue flaw, so nothing to do)

@rtibbles rtibbles merged commit b0eba58 into learningequality:release-v0.15.x Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants