Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary fetches on the library page. #8763

Merged
merged 2 commits into from Nov 29, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 22, 2021

Summary

  • Conditionalizes data loading on the Library page depending on whether a search is currently under way or not

Reviewer guidance

Should prevent repeated fetches of the root node data (less of a problem as they hit browser cache) and resume + resume contentnode progress


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 22, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Nov 22, 2021
@rtibbles rtibbles merged commit 62b0a01 into learningequality:release-v0.15.x Nov 29, 2021
@rtibbles rtibbles deleted the library_returns branch November 29, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants