Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text-align: right for rtl languages #8793

Merged
merged 3 commits into from Dec 2, 2021

Conversation

akash5100
Copy link
Contributor

@akash5100 akash5100 commented Dec 1, 2021

Summary

Fixed text-align: right for RTL languages, a problem reported by @pcenov

  • Added a condition to align text depending on value of RTL or LTR

References

closes #8771

before after
Screenshot from 2021-12-01 17-43-33 Screenshot from 2021-12-01 17-05-10
  • no changes to LTR languages

Screenshot from 2021-12-01 17-04-36


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob self-requested a review December 1, 2021 15:50
@MisRob
Copy link
Member

MisRob commented Dec 1, 2021

Thank you @akash5100, changes look good to me. It seems that we merged some updates of the same file recently, would you like to resolve conflicts as well? Then we will see if all automatic checks are passing and I will test the PR locally.

If you don't get to it, I can do it later. In any case, thank you for your contribution.

@MisRob MisRob added this to the 0.15.0 milestone Dec 1, 2021
Copy link
Contributor Author

@akash5100 akash5100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a merge conflict because of 'text-transform': 'capitalize', on the same line, So I accepted the upcoming changes and marked it as resolved.

@MisRob
Copy link
Member

MisRob commented Dec 1, 2021

I believe that the conflict was coming from #8791 where we removed 'capitalize' in favor of 'none', so let's keep the new value there to not cause regressions. The only change this PR needs to have is your update of the 'text-align' value.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's working as expected. Thank you, @akash5100

@MisRob MisRob merged commit 35665d0 into learningequality:release-v0.15.x Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Search - Category labels are not right aligned when viewed in RTL language
3 participants