Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the final Gujarati and Korean translations #8804

Conversation

radinamatic
Copy link
Member

@radinamatic radinamatic commented Dec 3, 2021

Summary

Commit does contain the new GU & KO translations, but we seem to have lost all PT-MZ ones in the proces... πŸ˜•

I did not do more than make i18n-download branch=release-v0.15.x just to see all Mozambican strings being deleted.

LEDev2111 (take)  Running  - Oracle VM VirtualBox_002

Learn in Gujarati Learn in Korean
Selection_014 Selection_015

References

…

Reviewer guidance

Could you please check this locally, as I have no idea where did PT-MZ go.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic radinamatic added TODO: needs review Waiting for review i18n Issues with fonts and translations in localizations DEV: frontend labels Dec 3, 2021
@radinamatic radinamatic added this to the 0.15.0 milestone Dec 3, 2021
@indirectlylit
Copy link
Contributor

I am not sure!

I re-ran make i18n-download branch=release-v0.15.x and it added the files back, along with the rest of the changes in f1db6cd (pushed to your branch)

Let me know if you continue to see this and we can debug.

@radinamatic
Copy link
Member Author

Thank you, whichever πŸ‘» was that stole those strings in my initial commit, has successfully been exorcised... 😎

Good to go! πŸŽ‰

LEDev2111 (take)  Running  - Oracle VM VirtualBox_006

@indirectlylit indirectlylit merged commit 26a65f2 into learningequality:release-v0.15.x Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend i18n Issues with fonts and translations in localizations TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants