Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make display of attempts parallel between mobile and non-mobile display #8890

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Dec 10, 2021

Summary

  • Follow up from Android and UI responsive updates #8802 to use the same iconography and display for mobile and non-mobile attempt log list display
  • Allows KSelect to take slots for option and display customization
  • Uses this customization to display the dropdown and the selected value with styling consistent with the non-dropdown display
  • Displays using a <span> in mobile and <p> in non-mobile view to use space more efficiently.
  • Removes conditional display of the coach content icon.

References

Fixes #8888

Reviewer guidance

Any UI weirdness as a result?
Non-mobile:
nonmobile

Mobile:
mobile


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 10, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 10, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me but I ran into a couple spots with some UI weirdness:

  1. The coach content icon items at ~tablet width have a different width than the rest:
wonky-question-names.mp4
  1. (I think this is unrelated to your work so not a blocker) "In progress". The icon centers as if there would be a "N minute ago" string under the label like when it is Complete making it off center in this case:

image

@radinamatic
Copy link
Member

Nice, I'm seeing the coach icons on the mobile phone, same as on desktop! 👍🏽

Selection_027

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do the super deep dive, but interacting with the lessons/quizzes and syncing seem to be working without issues.

@rtibbles
Copy link
Member Author

I'll fix up the issues that @nucleogenesis identified here.

@rtibbles
Copy link
Member Author

Updated to make sure that the coach content icon never causes odd styling, and that it never gets wrapped:

responsivecoachcontet

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coach icon styling weirdness addressed

@marcellamaki marcellamaki merged commit 898d980 into learningequality:release-v0.15.x Dec 17, 2021
@rtibbles rtibbles deleted the try_the_best_you_can branch December 17, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On small breakpoints attempt log list loses icon based information
4 participants