Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create message JSON files for 'en' #8912

Merged
merged 2 commits into from Dec 14, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Due to a change in our webpack build process message files for the 'en' language code no longer get generated at build time
  • This updates our message file generation code to create message files for english from the default messages
  • Updates our .gitignore to no longer ignore en message files
  • Commit the latest en message files

References

Fixes #8908

Reviewer guidance

Do you get any missing translation warnings in English? (most likely culprit is when using a perseus exercise)


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 13, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 13, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spun it up and seeing this - not sure if it's related directly to this PR

image

@rtibbles
Copy link
Member Author

I think that's this issue? #8829

@radinamatic
Copy link
Member

I did about 8 different Perseus exercises and a cursory walk-through other main pages, no missing EN strings! 💯

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:!

@rtibbles rtibbles merged commit 310b20c into learningequality:release-v0.15.x Dec 14, 2021
@rtibbles rtibbles deleted the english_strings branch December 14, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate JSON file with strings in English
3 participants