New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copies link on hybrid learning content cards #8936
Add copies link on hybrid learning content cards #8936
Conversation
Yesssss!!!! I was frantically searching for this to take screenshot for the user docs... 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ironically, not a wide array of changes (note because copies is conditionally annotated, this probably works, but these guards seem safer).
kolibri/plugins/learn/assets/src/views/HybridLearningContentCard/index.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/views/HybridLearningContentCardListView.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/views/HybridLearningContentCard/index.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Tibbles <richard@learningequality.org>
Co-authored-by: Richard Tibbles <richard@learningequality.org>
Co-authored-by: Richard Tibbles <richard@learningequality.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, discovered some issues in manual testing on mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
Summary
Ensures copies count appears on the content card, not just on list/bookmarks view and resources card
References
Fixes #8913
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)