Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copies link on hybrid learning content cards #8936

Conversation

marcellamaki
Copy link
Member

Summary

Ensures copies count appears on the content card, not just on list/bookmarks view and resources card

References

Fixes #8913

Screen Shot 2021-12-15 at 6 40 12 PM


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic
Copy link
Member

Yesssss!!!! I was frantically searching for this to take screenshot for the user docs... 🎉

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, not a wide array of changes (note because copies is conditionally annotated, this probably works, but these guards seem safer).

marcellamaki and others added 3 commits December 16, 2021 10:23
Co-authored-by: Richard Tibbles <richard@learningequality.org>
Co-authored-by: Richard Tibbles <richard@learningequality.org>
Co-authored-by: Richard Tibbles <richard@learningequality.org>
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, discovered some issues in manual testing on mobile.

@rtibbles
Copy link
Member

In mobile layout, clicking on the copies button doesn't do anything:

nocopiesonmobile

Works fine on a tablet layout though:
tabletok

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@rtibbles rtibbles merged commit cc55ffa into learningequality:release-v0.15.x Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HybridLearningContentCard is missing handling for copies
3 participants