Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox bookmarks cards focus outline #9409

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented May 5, 2022

Summary

Updates focus outline styles on Bookmarks cards to ensure proper styling on firefox

References

Fixes #9192
Screen Shot 2022-05-05 at 2 23 28 PM

Before:
bookmarks-navigation-firefox

Reviewer guidance

Use tab navigation on to test focus outline on bookmarks page in Firefox. Outline should properly surround the card.
Should not cause regressions on Chrome or Safari (or IE)


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki added TAG: a11y Affecting accessibility TODO: needs review Waiting for review labels May 5, 2022
@radinamatic
Copy link
Member

Fix confirmed in Firefox on Linux, and no regression noted in Chrome. 👏🏽
Let's wait for @pcenov to confirm that Safari is regression-less, and will approve. Thank you!

@pcenov
Copy link
Member

pcenov commented May 9, 2022

Confirmed - the focus outline is fixed in Safari as well.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: a11y Affecting accessibility TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants