Content dir argument #9463
Content dir argument #9463
Conversation
| @@ -377,7 +397,9 @@ def _transfer( # noqa: max-complexity=16 | |||
| f = files_to_download.pop() | |||
| filename = get_content_file_name(f) | |||
| try: | |||
| dest = paths.get_content_storage_file_path(filename) | |||
| dest = paths.get_content_storage_file_path( | |||
| filename, contentfolder=content_dir | |||
There was a problem hiding this comment.
Nit: maybe it's better to use the same variable name everywhere, eg renaming the new CLI parameter to --content-folder. Or do you prefer to use "content dir" as the exposed name and "contentfolder" as the internal name?
There was a problem hiding this comment.
CONTENT_DIR is the configuration option and it's used in other places, so I think it's better to use content-dir for this option.
|
1 test needs an update due to the change in function signature breaking an assertion call. Linting is failing - I'd suggest installing |
danigm
force-pushed
the
content-dir-argument
branch
from
4352ab9
to
c960961
Compare
danigm
force-pushed
the
content-dir-argument
branch
from
c960961
to
4716380
Compare
I've just fixed the linting issues, sorry for that, I didn't have the |
danigm
force-pushed
the
content-dir-argument
branch
from
81f87a6
to
8f351c4
Compare
Summary
Add
--content_diroption to theimportchannelandimportcontentcommands.This will allow to update content in an external device when running the application with the
CONTENT_FALLBACK_DIRSconfiguration.