Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing search results in coach quiz creation #9522

Merged

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Jun 20, 2022

Summary

Ensures cards display "inSearchMode"

Also adds a condition to the display of the "select from bookmarks" so it only shows up when there are bookmarks (otherwise, quite confusing)

References

Fixes #9520
quiz-search

Reviewer guidance

Does searching within "create quiz" yield results of available exercises?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Jun 20, 2022
@radinamatic
Copy link
Member

Search field is back for quizzes!!! 💯

search

@marcellamaki I noticed this slight misalignment of the buttons in the bottom bar after searching, let me know if it's better to open a separate issue or it can be fixed here...

misaligned

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search is back, yey! 👍🏽

@rtibbles
Copy link
Member

This only changed JS code, and the JS part of the build completed successfully. The Python failure is fixed in the release-v0.15.x branch, so this is safe to merge.

@rtibbles rtibbles merged commit 8d3eddf into learningequality:release-v0.15.x Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants