Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force translations in bulk export/import of user data #9557

Merged

Conversation

jredrejo
Copy link
Member

Summary

After some refactoring in the csv functions, the strings that were translated in the backend were not being translated or serialized in json format when they were still a lazy proxy

This PR:
a) forces all the translation scafolding to be active before calling labeling functions
b) ensures the errors are fully converted to string and not lazy functions before being serialized

References

Closes: #9554

Reviewer guidance

When the server is set to other language different than English check that:
a) Bulk export in the Facility-Data tab works fine, check the exported csv file has its headers translated (if using a language Kolibri supports)
b) Modify the exported csv to introduce error, and import it: It should show the error messages correctly translated in the web UI (while triggering an exception in the server console)
c) tests pass

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Jul 11, 2022
@jredrejo jredrejo added this to the Planned Patch 4: Coach usability improvements milestone Jul 11, 2022
@jredrejo jredrejo requested a review from rtibbles July 11, 2022 15:47
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, if the actions so yes, then so shall we merge!

@jredrejo jredrejo merged commit 3496b82 into learningequality:release-v0.15.x Jul 11, 2022
@jredrejo jredrejo deleted the force_translations_in_bulk branch July 11, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants