Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use multiprocessing for downloads. #9560

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 12, 2022

Summary

  • A previously unreported regression from Import content issue fixes #9242 would result in errors during content import if worker multiprocessing is used
  • Disables use of multiprocessing for file downloads in importcontent
  • Does this via a minimal fix to preserve the code paths for future usage and fixing

Reviewer guidance

Run kolibri with the environment variable KOLIBRI_USE_WORKER_MULTIPROCESSING=True ensure that import content works as expected.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 12, 2022
@rtibbles rtibbles added this to the Planned Patch 4: Coach usability improvements milestone Jul 12, 2022
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical and harmless

@rtibbles rtibbles merged commit d150cb3 into learningequality:release-v0.15.x Jul 12, 2022
@rtibbles rtibbles deleted the multiprocess_download branch July 12, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants