Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting back future bcs seems to be needed for past #8

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

ivanistheone
Copy link

This is because I ran into this error:

sushi-chef-african-storybook> ./chef.py --reset --thumbnails --token=/Users/ivan/.studiotoken
Traceback (most recent call last):
  File "./chef.py", line 22, in <module>
    from ricecooker.chefs import SushiChef
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/ricecooker/chefs.py", line 16, in <module>
    from .utils.jsontrees import read_tree_from_json
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/ricecooker/utils/jsontrees.py", line 5, in <module>
    from ricecooker.classes import files, nodes, questions
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/ricecooker/classes/files.py", line 25, in <module>
    from pressurecooker.subtitles import build_subtitle_converter_from_file
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/pressurecooker/subtitles.py", line 2, in <module>
    from pycaption import CaptionSet, WebVTTWriter
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/pycaption/__init__.py", line 1, in <module>
    from .base import (
  File "/Users/ivan/Projects/FLECode/sushi-chef-african-storybook/venv/lib/python3.7/site-packages/pycaption/base.py", line 1, in <module>
    from past.utils import old_div

Apparently the future package does not obey the "grep rule" and defines builtins and past module namespaces, see https://python-future.org/compatible_idioms.html

Locally pip installing future fixed the issue so I believe putting back the future depends will fix the above error.

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, my bad! Approving now if it's blocking your work.

I wonder if we can update those usages? I could follow up later with that.

@ivanistheone ivanistheone merged commit 1f1139a into py27 Mar 30, 2020
@ivanistheone
Copy link
Author

@bjester n.p. at all on ricecooker side, but please push a 2.1.0-alpha2 to PyPI just in case studio develop and vue-refactor branches run into this.

@bjester
Copy link
Member

bjester commented Mar 30, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants