New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize testcontent dir + fix for description length issue #235 #245
Organize testcontent dir + fix for description length issue #235 #245
Conversation
@kollivier This morning I was trying to fix a flaky test file, and ended up implementing a good part of the cleanup you suggested in #243 This is what
And after running tests:
Running |
|
||
@pytest.fixture | ||
def minimal_html_filename(): | ||
return 'b3f06ea298da23eee1d231795655e01b.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixture was not used by any tests, so removing.
52a2db1
to
3c12f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The channel validation/truncate_fileds normally happens later on in the upload process, so I added an early call to truncate_fields to avoid #235
I tested manually on command line. If description is > 400 chars, prints:
and only first 400 chars got uploaded to Studio, see here.