Set default learning_activity based on node kind in TreeNode #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would the mapping be worthwhile to put into LE Utils instead @rtibbles ? Or -- maybe as a follow-up to put onto the list of things we'll do when we get around to reworking LE Utils down the road? |
nucleogenesis
force-pushed
the
set-learning-activities-by-default
branch
from
ff0923c
to
0aa2323
Compare
rtibbles
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the TreeNode constructor, use kind_activity_map borrowed from Kolibri to map the node's
kindto a particular learning activity.If
learning_activitiesis provided to the constructor, then that is used. However, if it's not provided or is empty, then we refer to the map to provide a default learning activity.Closes #451
Reviewer guidance
Are the two little tests sufficient? Any possible regressions?