Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue button on the Terms of servivce modal is not working #4669

Closed
akolson opened this issue Aug 22, 2024 · 3 comments · Fixed by #4670
Closed

Continue button on the Terms of servivce modal is not working #4669

akolson opened this issue Aug 22, 2024 · 3 comments · Fixed by #4670
Assignees
Labels
bug P0 - critical Priority: Release blocker or regression TAG: regression

Comments

@akolson
Copy link
Member

akolson commented Aug 22, 2024

Observed behavior

Agreeing to the terms and clicking on the Continue button on the Terms of service is not working

Expected behavior

  • The continue button should be clickable and should move you to the Privacy modal. It might also be good to check that the Close button on the Privacy modal works as expected

User-facing consequences

  • A first time user is unable to proceed past these screens and thus can't use Studio.

Errors and logs

TermsOfServiceModal.vue:16 
TypeError: Cannot read properties of undefined (reading 'getUTCFullYear') 
    at createPolicyKey (constants.js:112:1) 
    at VueComponent.<anonymous> (index.js:34:1) 
    at VueComponent.handleAcceptPolicy (PolicyModals.vue:83:1) 
    at invokeWithErrorHandling (vue.runtime.esm.js:1863:1) 
    at Proxy.invoker (vue.runtime.esm.js:2188:1) at invokeWithErrorHandling (vue.runtime.esm.js:1863:1) 
    at Vue.$emit (vue.runtime.esm.js:3903:1) 
    at accept (TermsOfServiceModal.vue:16:1) 
    at invokeWithErrorHandling (vue.runtime.esm.js:1863:1) 
    at VueComponent.invoker (vue.runtime.esm.js:2188:1)

Additional information

Steps to reproduce the issue

  1. Create a new user and login
  2. You are presented with the terms
  3. Agree to the terms and click on the Continue button

Usage Details

  • OS: MacOs
  • Browser: Chrome
  • URL: http://localhost:8080/en/channels/#/my-channels
  • Other information that may be relevant:
@akolson
Copy link
Member Author

akolson commented Aug 23, 2024

This issue was fixed by #4667.

@radinamatic
Copy link
Member

I seem to be unable to create a new account, getting a 403 error after pressing the Finish button.

403

@radinamatic
Copy link
Member

I was finally able to go through this workflow and it works, but what might be confusing and giving impression that the button is not working, is the fact that two modals, ToS and Privacy open one right after the other. Since they are both almost full screen and test-heavy, user may think that the button is not working as they press it, it goes inactive and then active again, but this time it's a Privacy modal, that the user is not noticing, since they are still looking at the button, not the heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 - critical Priority: Release blocker or regression TAG: regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants