Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing attributes from change objects #4278

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Sep 12, 2023

Summary

Description of the change(s) you made

This PR fixes frontend errors due to missing attributes on change objects. Particularly fixes the move and delete operations. oldObj and parent were missing in move operation and oldObj was missing for delete operation.

Manual verification steps performed

  1. Create a channel.
  2. Share it with another user.
  3. Create several nodes, and move the nodes.
  4. The changes should be reflected on other user's frontend without any console errors.

Reviewer guidance

How can a reviewer test these changes?

Performing manual verification steps should be enough.

References

Closes #4209.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from bjester September 12, 2023 10:13
@marcellamaki
Copy link
Member

Confirming that manual QA checks out here for both move and delete operations - the state correctly updates in the other user's browser (no matter who is making the change) without any errors in the console

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look correct, and accord with the defined fields in the Change classes.

@rtibbles rtibbles merged commit 3fa10e3 into learningequality:hotfixes Sep 13, 2023
9 checks passed
@pcenov
Copy link
Member

pcenov commented Sep 18, 2023

No issues observed while manually testing this one as well!

@bjester bjester mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants