Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly format node_id+channel_id query parameter #4530

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Apr 22, 2024

Summary

Description of the change(s) you made

  • Updates resource method getByNodeIdChannelId to use proper format for the query parameter
  • Updates other potential issues related to [node_id+channel_id]__in filtering

Manual verification steps performed

  1. Create public channel with some nodes and publish it
  2. Sign out
  3. Sign into Studio
  4. Create new channel (without opening the public channel)
  5. Click ADD and select 'Import from channels'
  6. Search for one of the public channel nodes
  7. Click the clipboard icon on the node

Reviewer guidance

How can a reviewer test these changes?

Follow the above steps

Are there any risky areas that deserve extra testing?

I did update some clipboard actions that seemed to be passing a flattened array for __in query

References

Fixes #4508

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct to me and clipboard action works as expected. Thanks @bjester

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I runned the code and confirmed that now clipboard is working fine!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened this PR, nodded sagely, and thought "this makes sense", then forgot to leave a review, so I'll pile on here!

@bjester
Copy link
Member Author

bjester commented Apr 23, 2024

Thanks all!

@bjester bjester merged commit d95e5a6 into learningequality:hotfixes Apr 23, 2024
9 checks passed
@akolson akolson mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants