Before entering Main, check for showPolicy query param to show policy #4609
+12
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
In
beforeRouteEnter
inMain.vue
we check theto.query.showPolicy
- if it's a valid policy it'll be shown to the user. Includes a check to help be sure this is the first page load.The URLs would be:
https://studio.learningequality.org/en/accounts?showPolicy=privacy_policy
https://studio.learningequality.org/ar/accounts?showPolicy=privacy_policy
https://studio.learningequality.org/es-es/accounts?showPolicy=privacy_policy
https://studio.learningequality.org/fr-fr/accounts?showPolicy=privacy_policy
https://studio.learningequality.org/pt-br/accounts?showPolicy=privacy_policy
https://studio.learningequality.org/en/accounts?showPolicy=terms_of_service
https://studio.learningequality.org/ar/accounts?showPolicy=terms_of_service
https://studio.learningequality.org/es-es/accounts?showPolicy=terms_of_service
https://studio.learningequality.org/fr-fr/accounts?showPolicy=terms_of_service
https://studio.learningequality.org/pt-br/accounts?showPolicy=terms_of_service
https://studio.learningequality.org/en/accounts?showPolicy=community_standards
https://studio.learningequality.org/ar/accounts?showPolicy=community_standards
https://studio.learningequality.org/es-es/accounts?showPolicy=community_standards
https://studio.learningequality.org/fr-fr/accounts?showPolicy=community_standards
https://studio.learningequality.org/pt-br/accounts?showPolicy=community_standards
Reviewer guidance
How can a reviewer test these changes?
Run the changes, then replace
studio.learningequality.org
in the URLs listed above with the one you use to access your testing instance and see that they work.Are there any risky areas that deserve extra testing?
Go back & forth. Sign in, out, etc. It should only show the policy if it is the initial load of the page.
References
Closes #4133
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)