Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always require an actor_id to identify the user who caused a specific event in a channel's history. #4615

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

Requires any edits to a channel that changed its soft deletion status or creation of a channel to pass the user_id for the user to whom that change should be attributed.
Consolidates all channel history creation and management onto the Channel model.
Adds and updates tests for the channel history.
Updates every instance in the code base that requires the new actor_id parameter.

This does not ensure history is created by queryset updates, or bulk model creation. Neither are used in our backend for channels, and it would be considerably involved to implement.

Manual verification steps performed

Tests written to ensure behaviour.

Reviewer guidance

How can a reviewer test these changes?

If the tests pass this should be good to go - I've left it as a draft for now in case I missed anything.

See issue below.

References

Fixes #4148

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles marked this pull request as ready for review July 24, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel (soft) deletion doesn't track the history of the change
1 participant