Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons cannot be overwritten by theme #21

Closed
amandadoughty opened this issue Jun 3, 2019 · 2 comments
Closed

Icons cannot be overwritten by theme #21

amandadoughty opened this issue Jun 3, 2019 · 2 comments
Assignees

Comments

@amandadoughty
Copy link

I expect almost all users will stick to the default alert colours and icons but we have had to change them. However they are hard coded and do not allow theme overrides.

I have attached a small patch to fix this.
block_advnotifications.diff.txt

@emyb
Copy link

emyb commented Jun 3, 2019

Hi @amandadoughty

Thanks for your work on this. Are you able to submit a Pull Request? It may not get merged until the lead maintainer returns from holiday.

Cheers

@zpottie
Copy link
Contributor

zpottie commented Jul 11, 2019

Hi @amandadoughty - thanks for highlighting this. I used and tweaked your patch and it is now supported in the plugin from caad44d.

@zpottie zpottie self-assigned this Jul 11, 2019
@zpottie zpottie closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants