Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution Guide should have an explanation of Travis #27

Closed
ghost opened this issue Dec 23, 2014 · 6 comments
Closed

Contribution Guide should have an explanation of Travis #27

ghost opened this issue Dec 23, 2014 · 6 comments
Assignees
@wei2912
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Dec 23, 2014

The current working version of the contribution guide (https://github.com/beingbrown/lysa/blob/f-contributing/contributing.md) does not discuss Travis. Before merging, it needs an explanation of how to ensure successful builds.
@ghost ghost assigned wei2912 Dec 23, 2014
@wei2912
Copy link

wei2912 commented Dec 23, 2014

I'll work on it tomorrow.

@pharpend
Copy link
Contributor

I agree, I barely even understand Travis-CI.

@wei2912
Copy link

wei2912 commented Dec 24, 2014

I need to finish #30 before I can work on this.

@ghost
Copy link
Author

ghost commented Dec 24, 2014

That's okay. @pharpend got me to go ahead and merge the contrib as is since travis is giving us trouble.

@wei2912 wei2912 mentioned this issue Dec 24, 2014
Merged
@wei2912
Copy link

wei2912 commented Dec 24, 2014

I've written the contributing guide for Travis; please take a look at it and give some comments. :)

@pharpend
Copy link
Contributor

It looks good! Thanks, @wei2912 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wei2912 wei2912

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wei2912 @pharpend