Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 120 spanish translation #122

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Issue 120 spanish translation #122

merged 4 commits into from
Feb 3, 2023

Conversation

azgcloudev
Copy link
Contributor

  • remove old es directory, it included old ltc format
  • created the spanish folder and add and complete phase 0

Copy link
Collaborator

@madebygps madebygps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabkumar7 translation is good but is it okay that those files were deleted?

@rishabkumar7
Copy link
Collaborator

@madebygps still waiting on the reply on to why welcome.md was deleted?

@azgcloudev
Copy link
Contributor Author

@madebygps I deleted the old ones because did not had the phases format

@rishabkumar7 I just noticed I missed the welcome, let me add it today

@rishabkumar7
Copy link
Collaborator

thanks @azgcloudev !

@azgcloudev
Copy link
Contributor Author

@rishabkumar7 I added the welcome.md page again

@madebygps
Copy link
Collaborator

@rishabkumar7 I think this is good to merge now?

@rishabkumar7 rishabkumar7 merged commit 40d33a6 into learntocloud:staging Feb 3, 2023
@rishabkumar7
Copy link
Collaborator

lgtm ✅

Copy link
Collaborator

@rishabkumar7 rishabkumar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants