Merge pull request #284 from learnweb/fix/no-groups-filter

Fix error for group filter with no groups
learnweb · Oct 19, 2023 · ad87194 · ad87194
2 parents a1f490b + e337e6a
commit ad87194
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/classes/ratings_and_allocations_table.php b/classes/ratings_and_allocations_table.php
@@ -603,6 +603,8 @@ function($o) {
                     },
                     $this->groupsofallchoices)))) {
                 $sql .= "," . $gmgroupid . ") ) ";
+            } else {
+                $sql .= "))";
             }
         } else if ($this->groupselect != 0) {
             $sql .= "AND u.id in ( SELECT gm.userid FROM {groups_members} gm WHERE gm.groupid= :groupselect ) ";

diff --git a/version.php b/version.php
@@ -25,7 +25,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2023101700;        // The current module version (Date: YYYYMMDDXX).
+$plugin->version   = 2023101900;        // The current module version (Date: YYYYMMDDXX).
 $plugin->requires = 2020061500;         // Requires Moodle 3.9+.
 $plugin->maturity = MATURITY_STABLE;
 $plugin->release = 'v4.3-r1';