Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BNS names in recipient field for sends #1840

Closed
friedger opened this issue Oct 19, 2021 · 13 comments · Fixed by #2787
Closed

Support BNS names in recipient field for sends #1840

friedger opened this issue Oct 19, 2021 · 13 comments · Fixed by #2787
Assignees
@edu-stx
Labels
area:bns enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@friedger
Copy link
Contributor

Currently, bns names are not accepted as recipients

Screenshot from 2021-10-19 10-19-16

Expected behaviour
Allow to enter a bns name in preview and show the resolved address + bns name in final screen
@xanbots
Copy link

xanbots commented Oct 19, 2021

Yes please, big +1

@markmhendrickson markmhendrickson mentioned this issue Dec 2, 2021
Closed
@sleepiJoe
Copy link

+1 (we have the demand!)

@friedger
Copy link
Contributor Author

What should the UI look like? Should the preview just show the address and the name?

@markmhendrickson
Copy link
Collaborator

Assigning @landitus to design

@pors
Copy link

pors commented Apr 28, 2022

Interesting comment here: https://twitter.com/axopoa/status/1519572653278908417

I think we will need a autorenewal service for BTC names. Because it can be very dangerous if someone renews a name you own before you do.

@markmhendrickson markmhendrickson added the enhancement-p2 Critical functionality needed by few users, with no clear alternatives label Sep 29, 2022
@markmhendrickson
Copy link
Collaborator

From @kyranjamie:

Would be a great feature, but it isn't entirely trivial. We need to consider homoglyph attacks: I could buy bruffstаr.btc (Cyrillic letter а). We need to show address still in UI and warn against dodgy chars, similar to how vscode does

@friedger
Copy link
Contributor Author

homoglyph attacks are not possible because names are limited to a-z, 0-9 and - and _

@kyranjamie
Copy link
Collaborator

That does indeed limit the scope. We should still use a clear display type, so Oliver.btc is visibly different to OIiver.btc (capital i not L).

@markmhendrickson markmhendrickson changed the title Allow to transfer assets to a bns name Support BNS names in recipient field for sends Oct 17, 2022
@aulneau
Copy link
Contributor

aulneau commented Oct 20, 2022 •
edited

That does indeed limit the scope. We should still use a clear display type, so Oliver.btc is visibly different to OIiver.btc (capital i not L).

only lower case letters are allowed in BNS names

@RagnarLifthrasir
Copy link

+1 for BNS names in recipient fields.

@friedger
Copy link
Contributor Author

A blocker is still hirosystems/stacks-blockchain-api#1333

@aulneau
Copy link
Contributor

aulneau commented Oct 21, 2022

A blocker is still hirosystems/stacks-blockchain-api#1333

does not need to be a blocker, you can use the NFT history endpoint (gamma does this)

see https://discord.com/channels/621759717756370964/909867922971820102/1033008587804520459

yes, you can use the NFT history endpoint but you'll have to provide the name Clarity encoded. This is an example for eliherf.stacksparrot: https://stacks-node-api.mainnet.stacks.co/extended/v1/tokens/nft/history?asset_identifier=SP000000000000000000002Q6VF78.bns::names&value=0x0c00000002046e616d650200000007656c6968657266096e616d657370616365020000000c737461636b73706172726f74

@friedger
Copy link
Contributor Author

does not need to be a blocker, you can use the NFT history endpoint (gamma does this)

How do we reach all developers to switch from one api endpoint to the other? Seems not an option

@markmhendrickson markmhendrickson linked a pull request Nov 2, 2022 that will close this issue
Support BNS recipients #2787
Merged
@edu-stx edu-stx mentioned this issue Nov 5, 2022
Merged
edu-stx added a commit that referenced this issue Nov 10, 2022
@edu-stx
feat: support bns recipients, closes #1840
e5ddf57
edu-stx added a commit that referenced this issue Nov 10, 2022
@edu-stx
feat: support bns recipients, closes #1840
ad6deb1
edu-stx added a commit that referenced this issue Nov 11, 2022
@edu-stx
feat: support bns recipients, closes #1840
29601b0
edu-stx added a commit that referenced this issue Nov 11, 2022
@edu-stx
feat: support bns recipients, closes #1840
8790e3e
edu-stx added a commit that referenced this issue Nov 11, 2022
@edu-stx
feat: support bns recipients, closes #1840
9db23d0
edu-stx added a commit that referenced this issue Nov 15, 2022
@edu-stx
feat: support bns recipients, closes #1840
014c168
edu-stx added a commit that referenced this issue Nov 15, 2022
@edu-stx
feat: support bns recipients, closes #1840
55bf5ef
@edu-stx edu-stx mentioned this issue Nov 16, 2022
Merged
3 tasks
edu-stx added a commit that referenced this issue Nov 16, 2022
@edu-stx
feat: support bns recipients, closes #1840
6dae61e
blockstack-devops pushed a commit that referenced this issue Nov 16, 2022
@semantic-release-bot
chore(release): 3.25.0
b010321 
## [3.25.0](v3.24.0...v3.25.0) (2022-11-16)

### Features

* send form amount field ([c8621bc](c8621bc))
* support bns recipients, closes [#1840](#1840) ([6dae61e](6dae61e))

### Bug Fixes

* missing address chars, closes [#2860](#2860) ([793f90a](793f90a))

### Internal

* remove unused suspense ([4cab35f](4cab35f))
@kyranjamie kyranjamie mentioned this issue Nov 23, 2022
Merged
blockstack-devops pushed a commit that referenced this issue Nov 24, 2022
@semantic-release-bot
chore(release): 3.26.0
1039598 
## [3.26.0](v3.25.0...v3.26.0) (2022-11-24)

### Features

* send form amount field ([ab3a10a](ab3a10a))
* send form details ([b6a54bb](b6a54bb))
* support bns recipients, closes [#1840](#1840) ([55bf5ef](55bf5ef))

### Bug Fixes

* amount input in extension ([9b31782](9b31782))
* **balances:** query correct balance, show microblock balance, closes [#2898](#2898) ([da58732](da58732))
* missing address chars, closes [#2860](#2860) ([95bee55](95bee55))
* theme analytics, closes [#2799](#2799) ([8c85177](8c85177))
* typo ([f5f68f3](f5f68f3))

### Internal

* add error handling to form ([fb19774](fb19774))
* base forms for all currencies ([3eec893](3eec893))
* be explicit about address, allow reuse for non-current account ([153b961](153b961))
* form field error styles ([7ebe8c9](7ebe8c9))
* home page with facade pattern ([c1bbd29](c1bbd29))
* improve errors, add focus state ([0d193af](0d193af))
* init new integration tests ([5de2613](5de2613))
* initial test forms ([601c4a8](601c4a8))
* initial value helper, inline error ([15fe88d](15fe88d))
* react query pattern, form routes ([7860ee9](7860ee9))
* remove coupling of balances types, subBalance ([de94f2c](de94f2c))
* remove okcoin ([b34e214](b34e214))
* remove unused suspense ([8369e32](8369e32))
* rename existing tests as legacy ([7b97265](7b97265))
* rename original balance queries with stx naming ([1770e3d](1770e3d))
* semantic form elements ([6f9b123](6f9b123))
* tightens rules against orphan files ([950569a](950569a))
* use factory fn ([b43159a](b43159a))
* validation schemas ([3cd15c5](3cd15c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edu-stx edu-stx

Labels
area:bns enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support BNS recipients leather-wallet/extension
10 participants
@markmhendrickson @landitus @pors @friedger @kyranjamie @aulneau @RagnarLifthrasir @xanbots @sleepiJoe @edu-stx