New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/arbitrary message signing structured data/i2387 #2405
Feat/arbitrary message signing structured data/i2387 #2405
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
90f1dda
to
789d612
Compare
789d612
to
2bd6f77
Compare
2bd6f77
to
8191fbc
Compare
@landitus Were you able to test with https://stacks-wallet-jznmyg9k2-blockstack.vercel.app/ ? |
Yes, thank you. Be sure to check the Figma for the text formatting. It doesn't need to be a Also, beware there's an extra space at the top of the text content which I'm not sure where it comes from. |
0da8a1e
to
124b2cb
Compare
@beguene I fixed this test on dev if you rebase it you should be ok |
Thanks a lot @timstackblock I will check it out. |
7c6aca2
to
250b7cb
Compare
8191fbc
to
54b2bf6
Compare
@landitus I updated the UI with dl dd markup. Let me know if it's fine. |
54b2bf6
to
3a99838
Compare
@beguene It's looking better now, but it's still difficult to read when there are nested elements. I just peaked at the code and with flexbox it will be quite hard to align the elements correctly. I tested a hierarchy and styling to be as simple as possible in a CodeSandbox, and maybe it can help you this PR: https://codesandbox.io/s/pensive-bas-utyx9m?file=/index.html Note that this code is very rough, so measures and color values are approximate to illustrate the path I would go for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added me comments above ☝️
Thanks a lot @landitus, I will try your solution. |
17591a2
to
baccd18
Compare
baccd18
to
ccbcda0
Compare
ccbcda0
to
3ae2d55
Compare
3ae2d55
to
3b27d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@landitus's comments yet to be addressed, but merging for now to release feature
Add support for signing structured data (ClarityValue)
The web wallet receives the ClarityValue serialized in hex format which is then deserialized to display in the UI in a human readable format. The serialized format is finallly hashed and signed when the user clicks 'Sign'
cc/ @kyranjamie @fbwoolf @beguene @He1DAr