fix: support SIP-018 for structured data signing

[beguene]

Try out this version of the Hiro Wallet - download extension builds.

This PR implements the updated version of SIP-018 stacksgov/sips#57
and fixes the following too

• return all signatures in RSV format
• display correct hash in the UI

closes #2443
closes #2460
closes #2419
closes #2463

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
stacks-wallet-web	❌ Failed (Inspect)		Jun 23, 2022 at 9:11AM (UTC)

[beguene]

@landitus Now the structured message also has a domain value like this

  const domain = tupleCV({
    name: stringAsciiCV('hiro.so'),
    version: stringAsciiCV('1.0.0'),
    'chain-id': uintCV(1),
  }); 

I added a message and domain header, but we could do a bit better. Let me know if you have something better.

[MarvinJanssen]

This (very) old concept drawing displayed the app name and version on the top. Maybe something like that is useful for the domain object? Additionally, perhaps it could show a suffix of (mainnet) or (testnet) based on the chain-id property.

[beguene]

thanks @MarvinJanssen I will try something like that.

[beguene]

updated popup

[markmhendrickson]

@beguene is this awaiting a design integration review from @landitus?

[beguene]

@markmhx No I am working on those test unit issues
https://github.com/hirosystems/stacks-wallet-web/runs/6985575450?check_suite_focus=true#step:5:825

The upgrade to the latest connect-ui v5.5.1 fails many tests. Those connect changes are not related to AMS but AMS support in connect is built on top of it, so the upgrade is necessary.
This should be the last thing pending for this PR.

[beguene]

@janniks I upgraded our connect to the latest version which includes your latest changes hirosystems/connect#234
It's failing many unit tests in the web-wallet via jest.
https://github.com/hirosystems/stacks-wallet-web/runs/6985575450?check_suite_focus=true#step:5:825
It looks like node_modules/@stacks/connect/dist/connect.cjs.development.js:13:20 is loading connect-modal.js via import instead of loading the connect-modal.cjs file which is not co-located next to the .js but is in the cjs folder instead.
I am trying to find a solution for the web wallet with some custom jest config
like

   moduleNameMapper: {
     '@stacks/connect-ui/dist/components/connect-modal':
       '<rootDir>/node_modules/@stacks/connect/node_modules/@stacks/connect-ui/dist/cjs/connect-modal.cjs.entry.js',
  },

without success.

It seems that connect should package it with the right import rather than having to change our web-wallet jest config.
I saw that you are working on this hirosystems/connect#238
Is it related ? Is there a solution that I can use right now ?

[janniks]

Yep, I think I'll revert the change and add as a separate module. Will ping you later with progress.

[beguene]

@timstackblock This is ready for QA. There are special button in test-app to test the different types of message.
cc: @markmhx @andresgalante

[beguene]

@fbwoolf There is nothing left for me to do on this PR. I will let you merge it whenever you need it.

[fbwoolf]

@beguene do all of the linked issues need to be QA'd by me here before merging or do you feel confident it can be merged and then tested with a release PR?

[beguene]

@fbwoolf It's up to you, you can maybe quickly try it, there are some buttons I added in the test-app.

[landitus]

updated popup

Sorry I missed this @beguene! Yep, those headers will do the trick just fine 👍