fix: broken tx signing with extension #674
Conversation
Deploy previewsDeploy previews for blockstack-app and blockstack-test-app are ready! Built with commit 2fff353. |
|
Thanks @hstove |
|
Transaction signing still doesn't seem to be working correctly the pop up appears but it is not successful when I attempt to sign the transaction it just disappears Video of the issue here |
|
@timstackblock I think I've gotten my wire crossed. I believe yesterday we said this bug was fixed during the mid-sprint meeting, so I added comment #602 (comment) to the linked issue. However, your comment above suggests it's not actually fixed. Does this PR or that issue need updating at this point? |
|
@timstackblock to verify this is indeed fixed across both Firefox and Chrome |
|
Double blockstack logo
|
|
@timstackblock I wouldn't worry about the logo issue or others unrelated to transaction signing with the extension here, given that this PR hasn't incorporated all fixes like that one from master yet (as seen with #669 (comment)). Does tx signing otherwise work? |
|
Blocked by #623 - auth with FF extension broken |
markmhendrickson
moved this from QA
to Ready for development
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
|
@hstove I believe we're unblocked here now? |
markmhendrickson
moved this from Ready for development
to Code review
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
markmhendrickson
removed this from Code review
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
|
will this fix ever make it to production? |
Transaction signing was broken in the extension. This is because transaction signing would open up the authenticator at the root path (
/), but that's not a valid path in the extension. You have to explicitly use/index.html.'Fixes #602