Refactor project to use a Cropper class #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd adding more tests for Cropper class
|
Fixes #47. Still need to update README.md to make this usable by anyone. |
|
This PR should include pictures for e.g. |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 91.81% 94.38% +2.56%
==========================================
Files 4 5 +1
Lines 220 267 +47
==========================================
+ Hits 202 252 +50
+ Misses 18 15 -3
Continue to review full report at Codecov.
|
leblancfg
changed the title
|
Leaves extra work to be done, but it a step forwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI functionality is left unchanged, but exposes a Python API that takes in a filepath or np.ndarray, and returns an np.ndarray if a face has been detected, or None otherwise.