Enabled use of Evolve CLI Placeholders with ':' in their value #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapPlaceholders function now splits the placeholder string into 2 substrings (key & value). Before, it could split placeholders into 3 or more substrings and then ignore the extra substrings. This happened if the placeholder has more than one ':' character. This change is useful when using a placeholder to define a file path, for example in a CREATE DATABASE script. Before this change, a placeholder with the value of "filename:C:\SqlServer\TestDb_data.mdf" will be mistakenly read by Evolve as "filename:C". After this change, a placeholder with the value of "filename:C:\SqlServer\TestDb_data.mdf" will be correctly read by Evolve as "filename:C:\SqlServer\TestDb_data.mdf".
|
Hello, Is there any chance this will get merged? We're trying to use placeholders to supply CLR assembly file paths in our deploy pipelines and currently cannot do so. |
|
Merged. You can download Evolve 3.2.0-alpha2 |
|
Great, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapPlaceholders function now splits the placeholder string into 2 substrings (key & value). Before, it could split placeholders into 3 or more substrings, and would then ignore the extra substrings. This happened if the placeholder string has more than one ':' character.
This change is useful when using a placeholder to define a file path, for example in a CREATE DATABASE script.
Before this change, a placeholder with the value of "filename:C:\SqlServer\TestDb_data.mdf" will be mistakenly read by Evolve as "filename:C".
After this change, a placeholder with the value of "filename:C:\SqlServer\TestDb_data.mdf" will be correctly read by Evolve as "filename:C:\SqlServer\TestDb_data.mdf".