Improvements to ranges, calculation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude supplementary days from week/month calculations. Introduce proleptic week. Re-work value ranges. Optimised plus/minus for days/week/months.
Small cosmetic change to using EPOCH_DAY_DIFFERENCE.
catull
changed the title
ledahulevogyre
merged commit f7ac065
into
ledahulevogyre:implement-french-republic-calendar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New empty ValueRange for ranges on supplementary days involving weeks and month calculation.
Epoch day is calculated in the constructor instead of dynamically, make it immutable.
Corrected hopefully the last reference to "French revolution" in favour of "French Republican".
Corrected/fixed all commented cases in the test class.
Does not depend on AbstractNile* classes anymore.